[SIP Beyond VoIP] bug in webrtc/applications/janus.py
Tijmen de Mes
tijmen at ag-projects.com
Thu Apr 16 20:05:59 CEST 2020
Hi Valentin,
I applied it with you as the author of the patch:
https://github.com/AGProjects/sylkserver/commit/5c25d5ed68e354b204b66182487febcf7acfe95b <https://github.com/AGProjects/sylkserver/commit/5c25d5ed68e354b204b66182487febcf7acfe95b>
Best regards,
Tijmen de Mes
—
AG Projects
> Op 16 apr. 2020, om 19:36 heeft Tijmen de Mes <tijmen at ag-projects.com> het volgende geschreven:
>
> Hi,
>
> Thanks! I checked it and you’re correct. I will apply the patch.
>
> Best regards
>
> Tijmen de Mes
> —
> AG Projects
>
>> Op 16 apr. 2020, om 16:43 heeft Valentin Kleibel <valentin at vrvis.at> het volgende geschreven:
>>
>> Hi,
>>
>> I think I found a small bug in the VideoroomPluginHandle destroy function.
>> The log function line in sylk/applications/webrtcgateway/janus.py:326 should use room instead of room.id, as room in this context already is an integer containing the room id.
>>
>> diff --git a/sylk/applications/webrtcgateway/janus.py b/sylk/applications/webrtcgateway/janus.py
>> index 82ed832..2cecec3 100644
>> --- a/sylk/applications/webrtcgateway/janus.py
>> +++ b/sylk/applications/webrtcgateway/janus.py
>> @@ -323,7 +323,7 @@ class VideoroomPluginHandle(JanusPluginHandle):
>> try:
>> self.message(janus.VideoroomDestroy(room=room))
>> except JanusError as e:
>> - log.warning('could not destroy video room %s: %s', room.id, e)
>> + log.warning('could not destroy video room %s: %s', room, e)
>>
>> def join(self, room, sdp, display_name=None):
>> if display_name:
>>
>>
>> Regards,
>> Valentin
>> _______________________________________________
>> SIPBeyondVoIP mailing list
>> SIPBeyondVoIP at lists.ag-projects.com
>> https://lists.ag-projects.com/mailman/listinfo/sipbeyondvoip
>
> _______________________________________________
> SIPBeyondVoIP mailing list
> SIPBeyondVoIP at lists.ag-projects.com
> https://lists.ag-projects.com/mailman/listinfo/sipbeyondvoip
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ag-projects.com/pipermail/sipbeyondvoip/attachments/20200416/15ae35a1/attachment.htm>
More information about the SIPBeyondVoIP
mailing list