<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi Valentin,<div class=""><br class=""></div><div class="">I applied it with you as the author of the patch:</div><div class=""><a href="https://github.com/AGProjects/sylkserver/commit/5c25d5ed68e354b204b66182487febcf7acfe95b" class="">https://github.com/AGProjects/sylkserver/commit/5c25d5ed68e354b204b66182487febcf7acfe95b</a></div><div class=""><br class=""></div><div class="">Best regards,</div><div class=""><br class=""></div><div class="">Tijmen de Mes</div><div class="">—</div><div class="">AG Projects<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">Op 16 apr. 2020, om 19:36 heeft Tijmen de Mes <<a href="mailto:tijmen@ag-projects.com" class="">tijmen@ag-projects.com</a>> het volgende geschreven:</div><br class="Apple-interchange-newline"><div class=""><div class="">Hi,<br class=""><br class="">Thanks! I checked it and you’re correct. I will apply the patch.<br class=""><br class="">Best regards<br class=""><br class="">Tijmen de Mes<br class="">—<br class="">AG Projects<br class=""><br class=""><blockquote type="cite" class="">Op 16 apr. 2020, om 16:43 heeft Valentin Kleibel <<a href="mailto:valentin@vrvis.at" class="">valentin@vrvis.at</a>> het volgende geschreven:<br class=""><br class="">Hi,<br class=""><br class="">I think I found a small bug in the VideoroomPluginHandle destroy function.<br class="">The log function line in sylk/applications/webrtcgateway/janus.py:326 should use room instead of <a href="http://room.id" class="">room.id</a>, as room in this context already is an integer containing the room id.<br class=""><br class="">diff --git a/sylk/applications/webrtcgateway/janus.py b/sylk/applications/webrtcgateway/janus.py<br class="">index 82ed832..2cecec3 100644<br class="">--- a/sylk/applications/webrtcgateway/janus.py<br class="">+++ b/sylk/applications/webrtcgateway/janus.py<br class="">@@ -323,7 +323,7 @@ class VideoroomPluginHandle(JanusPluginHandle):<br class=""> try:<br class=""> self.message(janus.VideoroomDestroy(room=room))<br class=""> except JanusError as e:<br class="">- log.warning('could not destroy video room %s: %s', <a href="http://room.id" class="">room.id</a>, e)<br class="">+ log.warning('could not destroy video room %s: %s', room, e)<br class=""><br class=""> def join(self, room, sdp, display_name=None):<br class=""> if display_name:<br class=""><br class=""><br class="">Regards,<br class="">Valentin<br class="">_______________________________________________<br class="">SIPBeyondVoIP mailing list<br class=""><a href="mailto:SIPBeyondVoIP@lists.ag-projects.com" class="">SIPBeyondVoIP@lists.ag-projects.com</a><br class="">https://lists.ag-projects.com/mailman/listinfo/sipbeyondvoip<br class=""></blockquote><br class="">_______________________________________________<br class="">SIPBeyondVoIP mailing list<br class=""><a href="mailto:SIPBeyondVoIP@lists.ag-projects.com" class="">SIPBeyondVoIP@lists.ag-projects.com</a><br class="">https://lists.ag-projects.com/mailman/listinfo/sipbeyondvoip<br class=""></div></div></blockquote></div><br class=""></div></body></html>