[SIP Beyond VoIP] Important: python-sipsimple_0.31.0 is incompatible with python-msrplib-0.15.0

ANIL KARADAĞ anil.karadag at gmail.com
Wed Jan 30 10:08:43 CET 2013


Yes, I agree with you. In addition this is an important bug.


I checked the "*received_illegal_data" *method is never a member of
sipsimple/streams/msrp.py.NotificationProxyLogger class.


I added the below block to skip the problem in
sipsimple/streams/msrp.py.NotificationProxyLogger class;

def received_illegal_data(self, data, transport):
        self.error("received illegal MSRP data %s" %data)


If send an invalid MSRP data that does not starts with "MSRP" key and
msrp_trace is TRUE, the library writes a error log message to
msrp_trace.txt, for example;

2013-01-30 10:53:07.366042 [sylk-server 1112]: error: received illegal MSRP
data ^WpõÃHèlª:©Ã<8c><80>^X^@zö^V^@^@^A^A^H
^E¬O²^NïÃ<8b>MSRP e5c8b15dfa0815e9 SEND^M

2013-01-30 10:53:07.366557 [sylk-server 1112]: error: received illegal MSRP
data To-Path: msrp://1.1.1.1:2855/9c2125e6351428d54c89;tcp^M

2013-01-30 10:53:07.366849 [sylk-server 1112]: error: received illegal MSRP
data From-Path: msrp://1.1.1.2:54758/44727d3f7d1fb7201264;tcp^M

2013-01-30 10:53:07.367291 [sylk-server 1112]: error: received illegal MSRP
data Message-ID: 5c09016beec0ed21^M

2013-01-30 10:53:07.367404 [sylk-server 1112]: error: received illegal MSRP
data Byte-Range: 1-0/0^M

2013-01-30 10:53:07.367509 [sylk-server 1112]: error: received illegal MSRP
data -------e5c8b15dfa0815e9$^M



[1]
http://sipsimpleclient.org/projects/sipsimpleclient/repository/revisions/3255/entry/sipsimple/streams/msrp.py


thanks

On Wed, Jan 30, 2013 at 10:22 AM, Adrian Georgescu <ag at ag-projects.com>wrote:

> I do not see that method either. It seems to be missing from the code but
> is called in several places.
>
> So is not a question of unsatisfied dependencies, is  a bug that needs to
> be fixed.
>
> Adrian
>
>
> On Jan 29, 2013, at 5:03 PM, ANIL KARADAĞ wrote:
>
> Hi Adrian/ Saúl,
>
>
>
> I use python-msrplib-0.15.0 (python-msrplib-0.15.0.tar.gz) and
> python-sipsimple_0.31.0 (python-sipsimple-0.31.0.tar.gz) but get the
> following error when send invalid data, which does not start with "MSRP"
>
>
>
> Traceback (most recent call last):
> File
> "/usr/lib64/python2.6/site-packages/Twisted-12.2.0-py2.6-linux-x86_64.egg/twisted/internet/posixbase.py",
> line 626, in _doReadOrWrite
>     why = selectable.doRead()
> File
> "/usr/lib64/python2.6/site-packages/Twisted-12.2.0-py2.6-linux-x86_64.egg/twisted/internet/tcp.py",
> line 203, in doRead
>     return self._dataReceived(data)
> File
> "/usr/lib64/python2.6/site-packages/Twisted-12.2.0-py2.6-linux-x86_64.egg/twisted/internet/tcp.py",
> line 209, in _dataReceived
>     rval = self.protocol.dataReceived(data)
> File
> "/usr/lib64/python2.6/site-packages/Twisted-12.2.0-py2.6-linux-x86_64.egg/twisted/protocols/basic.py",
> line 564, in dataReceived
>     why = self.lineReceived(line)
> File "/usr/lib/python2.6/site-packages/msrplib/transport.py", line 55, in
> lineReceived
>     protocol.MSRPProtocol.lineReceived(self, line)
> File "/usr/lib/python2.6/site-packages/msrplib/protocol.py", line 502, in
> lineReceived
>    *self.msrp_transport.logger.received_illegal_data(line+self.delimiter,
> self.msrp_transport)*
> *AttributeError: 'NotificationProxyLogger' object has no attribute
> 'received_illegal_data'*
> *
> *
> *
> *
> I checked sipsimple/streams/msrp.py, the 'NotificationProxyLogger' class
> does not have the mentioned method.
> *
> *
> *Which msrplib release is compatible with the python-sipsimple_0.31.0?*
>
>
> thanks
>
> --
> Anıl KARADAĞ
> http://anilkaradag.info/blog
> _______________________________________________
> SIPBeyondVoIP mailing list
> SIPBeyondVoIP at lists.ag-projects.com
> http://lists.ag-projects.com/mailman/listinfo/sipbeyondvoip
>
>
>


-- 
Anıl KARADAĞ
http://anilkaradag.info/blog
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ag-projects.com/pipermail/sipbeyondvoip/attachments/20130130/237f5146/attachment-0001.html>


More information about the SIPBeyondVoIP mailing list