<div>Yes, I agree with you. In addition this is an important bug.</div><div><br></div><div><br></div><div>I checked the "<b>received_illegal_data" </b>method is never a member of sipsimple/streams/msrp.py.NotificationProxyLogger class. </div>
<div><br></div><div><br></div><div>I added the below block to skip the problem in sipsimple/streams/msrp.py.NotificationProxyLogger class;</div><div><br></div><div><div><font color="#000099">def received_illegal_data(self, data, transport):</font></div>
<div><font color="#000099"> self.error("received illegal MSRP data %s" %data)</font></div></div><div><br></div><div><br></div><div>If send an invalid MSRP data that does not starts with "MSRP" key and msrp_trace is TRUE, the library writes a error log message to msrp_trace.txt, for example;</div>
<div><br></div><div><div><font size="1" color="#666666">2013-01-30 10:53:07.366042 [sylk-server 1112]: error: received illegal MSRP data ^WpõÃHèlª:©Ã<8c><80>^X^@zö^V^@^@^A^A^H</font></div><div><font size="1" color="#666666">^E¬O²^NïÃ<8b>MSRP e5c8b15dfa0815e9 SEND^M</font></div>
<div><font size="1" color="#666666"><br></font></div><div><font size="1" color="#666666">2013-01-30 10:53:07.366557 [sylk-server 1112]: error: received illegal MSRP data To-Path: msrp://<a href="http://1.1.1.1:2855/9c2125e6351428d54c89;tcp">1.1.1.1:2855/9c2125e6351428d54c89;tcp</a>^M</font></div>
<div><font size="1" color="#666666"><br></font></div><div><font size="1" color="#666666">2013-01-30 10:53:07.366849 [sylk-server 1112]: error: received illegal MSRP data From-Path: msrp://<a href="http://1.1.1.2:54758/44727d3f7d1fb7201264;tcp">1.1.1.2:54758/44727d3f7d1fb7201264;tcp</a>^M</font></div>
<div><font size="1" color="#666666"><br></font></div><div><font size="1" color="#666666">2013-01-30 10:53:07.367291 [sylk-server 1112]: error: received illegal MSRP data Message-ID: 5c09016beec0ed21^M</font></div><div><font size="1" color="#666666"><br>
</font></div><div><font size="1" color="#666666">2013-01-30 10:53:07.367404 [sylk-server 1112]: error: received illegal MSRP data Byte-Range: 1-0/0^M</font></div><div><font size="1" color="#666666"><br></font></div><div><font size="1" color="#666666">2013-01-30 10:53:07.367509 [sylk-server 1112]: error: received illegal MSRP data -------e5c8b15dfa0815e9$^M</font></div>
</div><div><br></div><div><br></div><div><br></div><div>[1] <a href="http://sipsimpleclient.org/projects/sipsimpleclient/repository/revisions/3255/entry/sipsimple/streams/msrp.py">http://sipsimpleclient.org/projects/sipsimpleclient/repository/revisions/3255/entry/sipsimple/streams/msrp.py</a></div>
<div><br></div><div><br></div><div>thanks<br><br><div class="gmail_quote">On Wed, Jan 30, 2013 at 10:22 AM, Adrian Georgescu <span dir="ltr"><<a href="mailto:ag@ag-projects.com" target="_blank">ag@ag-projects.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">I do not see that method either. It seems to be missing from the code but is called in several places.<div>
<br></div><div>So is not a question of unsatisfied dependencies, is a bug that needs to be fixed.<span class="HOEnZb"><font color="#888888"><br><div><br></div><div>Adrian</div></font></span><div><br><div><br><div><div class="im">
<div>On Jan 29, 2013, at 5:03 PM, ANIL KARADAĞ wrote:</div><br></div><blockquote type="cite"><div><div class="h5"><div>Hi Adrian/<span style="line-height:16px;color:rgb(34,34,34);font-family:arial,sans-serif"> Saúl</span>,</div>
<div><br></div><div><br></div><div><br></div><div>I use python-msrplib-0.15.0 (python-msrplib-0.15.0.tar.gz) and python-sipsimple_0.31.0 (python-sipsimple-0.31.0.tar.gz) but get the following error when send invalid data, which does not start with "MSRP"</div>
<div><br></div><div><br></div><div><br></div><div><div>Traceback (most recent call last):</div><div>File "/usr/lib64/python2.6/site-packages/Twisted-12.2.0-py2.6-linux-x86_64.egg/twisted/internet/posixbase.py", line 626, in _doReadOrWrite</div>
<div> why = selectable.doRead()</div><div>File "/usr/lib64/python2.6/site-packages/Twisted-12.2.0-py2.6-linux-x86_64.egg/twisted/internet/tcp.py", line 203, in doRead</div><div> return self._dataReceived(data)</div>
<div>File "/usr/lib64/python2.6/site-packages/Twisted-12.2.0-py2.6-linux-x86_64.egg/twisted/internet/tcp.py", line 209, in _dataReceived</div><div> rval = self.protocol.dataReceived(data)</div><div>File "/usr/lib64/python2.6/site-packages/Twisted-12.2.0-py2.6-linux-x86_64.egg/twisted/protocols/basic.py", line 564, in dataReceived</div>
<div> why = self.lineReceived(line)</div><div>File "/usr/lib/python2.6/site-packages/msrplib/transport.py", line 55, in lineReceived</div><div> protocol.MSRPProtocol.lineReceived(self, line)</div><div>File "/usr/lib/python2.6/site-packages/msrplib/protocol.py", line 502, in lineReceived</div>
<div> <b> self.msrp_transport.logger.received_illegal_data(line+self.delimiter, self.msrp_transport)</b></div><div><font color="#cc0000"><b>AttributeError: 'NotificationProxyLogger' object has no attribute 'received_illegal_data'</b></font></div>
</div><div><font color="#cc0000"><b><br></b></font></div><div><font color="#cc0000"><b><br></b></font></div><div><font color="#333333">I checked sipsimple/streams/msrp.py, the 'NotificationProxyLogger' class does not have the mentioned method. </font></div>
<div><font color="#333333"><b><br></b></font></div><div><font color="#333333"><b>Which msrplib release is compatible with the python-sipsimple_0.31.0?</b></font></div><div><font color="#333333"><br></font></div><div><br>
</div>
<div>thanks</div><div><div><div><br></div>-- <br>Anıl KARADAĞ<br><a href="http://anilkaradag.info/blog" target="_blank">http://anilkaradag.info/blog</a>
</div></div></div></div><div class="im">
_______________________________________________<br>SIPBeyondVoIP mailing list<br><a href="mailto:SIPBeyondVoIP@lists.ag-projects.com" target="_blank">SIPBeyondVoIP@lists.ag-projects.com</a><br><a href="http://lists.ag-projects.com/mailman/listinfo/sipbeyondvoip" target="_blank">http://lists.ag-projects.com/mailman/listinfo/sipbeyondvoip</a><br>
</div></blockquote></div><br></div></div></div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Anıl KARADAĞ<br><a href="http://anilkaradag.info/blog">http://anilkaradag.info/blog</a>
</div>