[SIP Beyond VoIP] bug in webrtc/applications/janus.py

Valentin Kleibel valentin at vrvis.at
Thu Apr 16 16:43:09 CEST 2020


Hi,

I think I found a small bug in the VideoroomPluginHandle destroy function.
The log function line in sylk/applications/webrtcgateway/janus.py:326 
should use room instead of room.id, as room in this context already is 
an integer containing the room id.

diff --git a/sylk/applications/webrtcgateway/janus.py 
b/sylk/applications/webrtcgateway/janus.py
index 82ed832..2cecec3 100644
--- a/sylk/applications/webrtcgateway/janus.py
+++ b/sylk/applications/webrtcgateway/janus.py
@@ -323,7 +323,7 @@ class VideoroomPluginHandle(JanusPluginHandle):
          try:
              self.message(janus.VideoroomDestroy(room=room))
          except JanusError as e:
-            log.warning('could not destroy video room %s: %s', room.id, e)
+            log.warning('could not destroy video room %s: %s', room, e)

      def join(self, room, sdp, display_name=None):
          if display_name:


Regards,
Valentin


More information about the SIPBeyondVoIP mailing list